Document System.Type.MakeGenericSignatureType #2859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
GrabYourPitchforks,
jkotas,
steveharter,
rpetrusha and
mairaw
jkotas
approved these changes
Jul 29, 2019
jkotas
reviewed
Jul 29, 2019
| <param name="genericTypeDefinition">The generic type definition.</param> | ||
| <param name="typeArguments">An array of type arguments.</param> | ||
| <summary>Creates a generic signature type, which allows third party reimplementations of Reflection to fully support the use of signature types in querying type members.</summary> | ||
| <returns>A generic signature type.</returns> | ||
| <remarks>To be added.</remarks> |
There was a problem hiding this comment.
Should the remarks section be deleted?
There was a problem hiding this comment.
No, they should be left. Remarks that read "To be added." do not appear in the build.
rpetrusha
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
LGTM, @carlossanlop. I'll merge when the build completes successfully.
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source code: coreclr/src/System.Private.CoreLib/shared/System/Type.cs#L346
The git blame says it was introduced 11 months ago in this commit and with this PR.
Proposal: https://github.com/dotnet/corefx/issues/31798
I read the proposal and tried to come up with a description, but I'm not an expert in the area, and unfortunately the creator's username does not exist anymore (ghost).
@jkotas reviewed this, and the code seems to be related to System.Reflection, whose owners are @steveharter @GrabYourPitchforks . Can you please help ensure the description is clear enough? I promise it will only take a few minutes.